davidker / unisys

Master repository for new changes to drivers/staging/unisys and drivers/visorbus
Other
2 stars 1 forks source link

Move diagchannel.h #73

Closed arfvidsonUIS closed 8 years ago

davidker commented 8 years ago

I see a fix for this was put on the githubissue#68-upstream-next-2 branch. Once that branch gets through inspection we can close this issue as well.

davidker commented 8 years ago

When I do a cherry-pick of this fix it fails checkpatch with the following:

ERROR: code indent should use tabs where possible
#89: FILE: drivers/staging/unisys/include/visorbus.h:209:
+                DIAG_SEVERITY_VERBOSE = 0,$

WARNING: please, no spaces at the start of a line
#89: FILE: drivers/staging/unisys/include/visorbus.h:209:
+                DIAG_SEVERITY_VERBOSE = 0,$

ERROR: code indent should use tabs where possible
#90: FILE: drivers/staging/unisys/include/visorbus.h:210:
+                DIAG_SEVERITY_INFO = 1,$

WARNING: please, no spaces at the start of a line
#90: FILE: drivers/staging/unisys/include/visorbus.h:210:
+                DIAG_SEVERITY_INFO = 1,$

ERROR: code indent should use tabs where possible
#91: FILE: drivers/staging/unisys/include/visorbus.h:211:
+                DIAG_SEVERITY_WARNING = 2,$

WARNING: please, no spaces at the start of a line
#91: FILE: drivers/staging/unisys/include/visorbus.h:211:
+                DIAG_SEVERITY_WARNING = 2,$

ERROR: code indent should use tabs where possible
#92: FILE: drivers/staging/unisys/include/visorbus.h:212:
+                DIAG_SEVERITY_ERR = 3,$

WARNING: please, no spaces at the start of a line
#92: FILE: drivers/staging/unisys/include/visorbus.h:212:
+                DIAG_SEVERITY_ERR = 3,$

ERROR: code indent should use tabs where possible
#93: FILE: drivers/staging/unisys/include/visorbus.h:213:
+                DIAG_SEVERITY_PRINT = 4,$

WARNING: please, no spaces at the start of a line
#93: FILE: drivers/staging/unisys/include/visorbus.h:213:
+                DIAG_SEVERITY_PRINT = 4,$

total: 5 errors, 6 warnings, 0 checks, 32 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

NOTE: Whitespace errors detected.
      You may wish to use scripts/cleanpatch or scripts/cleanfile
davidker commented 8 years ago

@arfvidsonUIS, Erik, just wanted to let you know this gives me checkpatch warnings.

selltc commented 8 years ago

Greg committed the above-referenced patch to staging-next on 9/12 as:

So I am closing this.