search

davidker / unisys

Master repository for new changes to drivers/staging/unisys and drivers/visorbus
Other
2 stars 1 forks source link

Remove useless initialization #97

Closed wadgaonkarsam closed 7 years ago

wadgaonkarsam commented 7 years ago

Kanboard 24493 Github branch

davidker commented 7 years ago

Great job with the patch! Looks good, though looking at the issue, I'm not sure if your patch will allow us to close the patch. I think there are several other spots in the driver that greg would complain about if he had another eight hour flight to look through the code. We might want to comb through the code and see if we can find other spots or at least comb through his response some more to see if we can find some.

wadgaonkarsam commented 7 years ago

Thanks David! I'll keep looking for similar initializations in the code. I added back the memset in initialize_controlvm_payload_info().

davidker commented 7 years ago

Sameer, I picked up your latest patch and started to review it. The patch itself is fine, however, looking at your signed off line your name is all lowercase, are you sure you want that? The signed-off line is like a legal document and your name should be represented as a signature. Do you want me to fix it, or do you want respin?

davidker commented 7 years ago

Actually, I take it back about the patch itself is fine. You probably should have two patches one to do the removal and one to do the move down in the file.

davidker commented 7 years ago

The more I think about it, we can probably keep the patch as is, so ignore my previous comment.

wadgaonkarsam commented 7 years ago

Thank you David, for the inspection and updating the signed off line.

davidker commented 7 years ago

Committed at c4fe36cd262d5fe710ff9ee43cb99337e8b050de