davidker / unisys_attic

Stale branches from unisys.git go here.
Other
0 stars 0 forks source link

CAT: checkpatch: channel.h: Macro argument resuse - possible side-effects? #19

Closed davidker closed 7 years ago

davidker commented 7 years ago

Checkpatch is reporting these errors for channel.h:

drivers/staging/unisys/include/channel.h:45: CHECK: Macro argument reuse 'd' - possible side-effects? drivers/staging/unisys/include/channel.h:48: CHECK: Macro argument reuse 'd' - possible side-effects? drivers/staging/unisys/include/channel.h:81: CHECK: Macro argument reuse 'o' - possible side-effects? drivers/staging/unisys/include/channel.h:81: CHECK: Macro argument reuse 'n' - possible side-effects? drivers/staging/unisys/include/channel.h:217: CHECK: Macro argument reuse 'chan' - possible side-effects? drivers/staging/unisys/include/channel.h:217: CHECK: Macro argument 'chan' may be better as '(chan)' to avoid precedence issues drivers/staging/unisys/include/channel.h:217: CHECK: Macro argument reuse 'QHDRFLD' - possible side-effects? drivers/staging/unisys/include/channel.h:217: CHECK: Macro argument 'QHDRFLD' may be better as '(QHDRFLD)' to avoid precedence issues drivers/staging/unisys/include/channel.h:217: CHECK: Macro argument reuse 'QDATAFLD' - possible side-effects? drivers/staging/unisys/include/channel.h:217: CHECK: Macro argument 'QDATAFLD' may be better as '(QDATAFLD)' to avoid precedence issues drivers/staging/unisys/include/channel.h:217: CHECK: Macro argument reuse 'QDATATYPE' - possible side-effects?

To run checkpatch on this file:

Complexity: 1

davidker commented 7 years ago

Okay, this will be closed by other tickets or just isn't needed. Closing now.