davidkpiano / react-redux-form

Create forms easily in React with Redux.
https://davidkpiano.github.io/react-redux-form
MIT License
2.07k stars 251 forks source link

`retouched` is not set to true if user changes fields while `pending==true` #1195

Open Multihuntr opened 5 years ago

Multihuntr commented 5 years ago

The Problem

The purpose of the retouched field seems to be for indicating if the submitted information is different to the current information in the form. It is set to true when a user changes any constituent field while submitted==true, and retouched=false is set when submitting again. However, retouched is not affected by changes while pending==true which seems inconsistent with it's purpose. Perhaps I've misunderstood, but I couldn't find any documentation on retouched to check if this is intended behaviour. If there is documentation that I've missed, then I apologise. Else if this is intended, but not documented, can it become documented?

Steps to Reproduce

Call dispatch(actions.submit(formName, promise)), and before promise returns, interact with the form to change a field.

Expected Behavior

Changing a field at any point after submit has been called will set retouched=true.

Actual Behavior

Changing a field before promise has resolved doesn't set retouched=true

Reproducible Code Example

https://codepen.io/Multihuntr/pen/royaxL