Closed andrewmtam closed 4 years ago
Do you know why the build is failing?
Hiya - I do not :(. But I thought it might be ok because it looked like the last two PRs that were merged were failing too
Ooo I just figured out how to use the Travis CI UI lol:
The command "eval yarn --frozen-lockfile " failed. Retrying, 2 of 3.
I’ll take a quick look this morning
Hiya - just wanted to check back in here and let you know that I've fixed the failing tests and updated the PR!
Awesome, thanks so much for helping me get this merged!
Is there any protocol for bumping up the release number? Between master and the current release, it looks like there are not many changes:
https://github.com/davidkpiano/react-redux-form/compare/v1.16.14...master
I can put up another PR similar to this one that just bumps the patch version?
https://github.com/davidkpiano/react-redux-form/commit/346e93c9c7512cb12ccd7654855d6669f6dc7a6f
Hiya @davidkpiano,
Just a friendly bump here on thoughts for getting this released into a new version?
Thanks!
Clearing the cache on
mapStateToProps
causes performance issues for applications using a large redux store.This defers the clearing to
componentDidMount
.I confirmed that all of the tests that were added to initially test clearing the cache are still working:
https://github.com/davidkpiano/react-redux-form/pull/1184/files#diff-55bc9da456e5c128d620d4d263cb75b3R2046