davidkpiano / react-redux-form

Create forms easily in React with Redux.

https://davidkpiano.github.io/react-redux-form

MIT License

2.07k stars 251 forks source link

Closed andrewmtam closed 4 years ago

andrewmtam commented 4 years ago

Clearing the cache on mapStateToProps causes performance issues for applications using a large redux store.

This defers the clearing to componentDidMount.

I confirmed that all of the tests that were added to initially test clearing the cache are still working:

andrewmtam commented 4 years ago

1218

davidkpiano commented 4 years ago

Do you know why the build is failing?

andrewmtam commented 4 years ago

Hiya - I do not :(. But I thought it might be ok because it looked like the last two PRs that were merged were failing too

andrewmtam commented 4 years ago

Ooo I just figured out how to use the Travis CI UI lol:

The command "eval yarn --frozen-lockfile " failed. Retrying, 2 of 3.

I’ll take a quick look this morning

andrewmtam commented 4 years ago

Hiya - just wanted to check back in here and let you know that I've fixed the failing tests and updated the PR!

andrewmtam commented 4 years ago

Awesome, thanks so much for helping me get this merged!

Is there any protocol for bumping up the release number? Between master and the current release, it looks like there are not many changes:

I can put up another PR similar to this one that just bumps the patch version?

andrewmtam commented 4 years ago

Hiya @davidkpiano,

Just a friendly bump here on thoughts for getting this released into a new version?

Thanks!