search

davidlang42 / roland-rds

Library for working with Roland RDS files (live set keyboard patches)
GNU Affero General Public License v3.0
3 stars 0 forks source link

Default values in JSON schema #31

Closed davidlang42 closed 1 year ago

davidlang42 commented 1 year ago

The JSON schema should contain the default values optional (or oneOf) fields.

This is especially import for effect parameters (ChorusType, etc.) so that when the effect type is changed, the default set of parameters are provided rather than gibberish.

davidlang42 commented 1 year ago

See SchemaObject.metadata.default (https://docs.rs/schemars/latest/schemars/schema/struct.Metadata.html) Only need to be implemented for Parameter sets (Mfx, Reverb, Chorus)

davidlang42 commented 1 year ago

https://github.com/davidlang42/roland-rds/commit/5597d27a7e36051c8eb6ca6d6725cd00385d7b41