davidlang42 / roland-rds

Library for working with Roland RDS files (live set keyboard patches)
GNU Affero General Public License v3.0
3 stars 0 forks source link

Ignore tone remain if damper is disabled #47

Open davidlang42 opened 10 months ago

davidlang42 commented 10 months ago

If damper is disabled for a layer then assume it's safe to not tone remain that layer (this is helpful for tones that dont sustain after initial note down anyway, eg. pizz strings)

Also, assume that {Tone 939 "GM2 SFX", range A0-A0, transpose 0} means a dummy entry, which does not need to be tone remained (because that won't produce any sound anyway).

Actually better yet, have a method called "isSilence" which checks if that layer can only play silence, that is:

And if they can only play silence, then dont need to tone remain that layer. This means any silent layer can be used to help tone remain other tones without it having a carry through effect