search

davidlday / vscode-languagetool-linter

A from scratch redesign of LanguageTool integration for VS Code.
https://marketplace.visualstudio.com/items?itemName=davidlday.languagetool-linter
Apache License 2.0
158 stars 12 forks source link

files get linted upon opening despite `"languageToolLinter.enabled": false` #699

Closed j-lakeman closed 1 month ago

j-lakeman commented 5 months ago

To Reproduce Steps to reproduce the behavior:

  1. "languageToolLinter.enabled": false
  2. "languageToolLinter.lintOnOpen": true
  3. files get linted upon opening

Expected behavior "languageToolLinter.enabled": false should take precedence over "languageToolLinter.lintOnOpen": true

davidlday commented 1 month ago

Thanks for reporting this issue!

This looks like I left a legacy setting in there. VS Code provides the ability to enable/disable extensions in a workspace directly. If you go to Extensions and the Languagetool Linter, you should be able to right click and see "Disable (Workspace)" on the context menu that shows up. Before I remove the config item from the extension itself, can you verify that using the built-in feature works and addresses your problem, please?

image

If this addresses the issue, I'll remove the legacy config item as it'll continue to cause confusion.

j-lakeman commented 1 month ago

Confirming Disable (Workspace) working as expected.

davidlday commented 1 month ago

Excellent. I'm leaving this open until I get that old config item out.