davidlday / vscode-languagetool-linter

A from scratch redesign of LanguageTool integration for VS Code.
https://marketplace.visualstudio.com/items?itemName=davidlday.languagetool-linter
Apache License 2.0
158 stars 13 forks source link

Enable picky mode #756

Closed Prodeguerriero closed 2 months ago

Prodeguerriero commented 2 months ago

Is your feature request related to a problem? Please describe. I always use LT's Picky Mode when running the extension in the browser, so now I am used to LT being, well, picky. 😬

Describe the solution you'd like I'd like to be able to enable picky mode for the linter.

Describe alternatives you've considered None, really, besides dealing with it. It's not exactly a dealbreaker.

Additional context N/A

davidlday commented 2 months ago

Thanks for opening this feature request!

I think I have it working, but could you please provide a small example of a document that gets different results in picky vs. default mode so I can add it to the testing suite?

Prodeguerriero commented 2 months ago

I'm not home right now, but I'll do it asap.

Otherwise, the first rule that comes to mind is to have a comma after "e.g.". If you omit the comma, picky mode should flag it, normal mode will not.

Gabriele Bartoli Gender pronouns: he, him, his.

On Sat, Sep 7, 2024, 00:21 David L. Day @.***> wrote:

Thanks for opening this feature request!

I think I have it working, but could you please provide a small example of a document that gets different results in picky vs. default mode so I can add it to the testing suite?

— Reply to this email directly, view it on GitHub https://github.com/davidlday/vscode-languagetool-linter/issues/756#issuecomment-2334885668, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADTSWIS7LLLOSF6S6DLRLO3ZVITGVAVCNFSM6AAAAABNT7YXBWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZUHA4DKNRWHA . You are receiving this because you authored the thread.Message ID: @.***>

Prodeguerriero commented 2 months ago

Nor sure if you still need a sample, but here it is:

I need a sentence that will break because of an obvious mistoke.
Then, I require one that includes no mistakes at all. I.e., the perfect sentence.
Finally, one that will trigger picky mode. I.e. this one.
davidlday commented 2 months ago

Sorry for the delay. Creating an automated test case turned out to be a lot trickier than I expected. I have validated that it works by running the extension and toggling the settings. Will release shortly.

Prodeguerriero commented 2 months ago

Thanks a lot, sir.

davidlday commented 2 months ago

You're welcome! Let me know if you run into any issues, please!