Rotary encoder button should use pull-up resistor

davidledwards / gps-clock

A GPS-synchronized digital clock

Apache License 2.0

8 stars 3 forks source link

Rotary encoder button should use pull-up resistor #3

Closed davidledwards closed 4 years ago

davidledwards commented 4 years ago

The push button on the rotary encoder is not properly using a pull-up resistor. It is wired when closed to pull to ground, but the pin on the Uno board is not configured as INPUT_PULLUP.

davidledwards commented 4 years ago

After examination of the source code associated with the library used to interface with the encoder, it turns out that that pins are being properly configured.