davidmalcolm / gcc-python-plugin

GCC plugin that embeds CPython inside the compiler
GNU General Public License v3.0
197 stars 58 forks source link

Is it possible that GimpleCond's true_label & false_label are None? #152

Open aqjune opened 5 years ago

aqjune commented 5 years ago

I am scanning through GIMPLE instructions generated from this C code:

void if_simple() {
  int c = cond();
  if (c) {
    f1();
  }
}

The generated GIMPLE is like this:

if_simple ()
{
  int c;

  <bb 2> [100.00%]:
  c_4 = cond ();
  if (c_4 != 0)
    goto <bb 3>; [36.64%]
  else
    goto <bb 4>; [63.36%]

  <bb 3> [36.64%]:
  f1 ();

  <bb 4> [100.00%]:
  return;

}

However, in Python, I'm getting gcc.GimpleCond which has true_label & false_label set to None.

Is there anything I'm missing or is it a bug?

Thanks

davidmalcolm commented 5 years ago

Internally, these are coming from gimple_cond_true_label and gimple_cond_false_label, which presumably are returning NULL, and this is being handled at the Python level as None.

I'm not sure how they could be NULL. When is your code running, compared to the various passes?

aqjune commented 5 years ago

My callback function is registered before optimized pass.

tom91136 commented 1 week ago

Just adding some information in case someone finds this. After CFG all direct control flows in the language (i.e goto) are lowered to individual basic blocks with predecessors and successors, with an optional PHI node for input. The CFG step also deletes the labels for the cond node so the only way to recover this is to inspect each basic block's edges.