search

davidmarkclements / 0x

🔥 single-command flamegraph profiling 🔥
MIT License
3.23k stars 106 forks source link

Entries should have more than a single type #164

Closed BridgeAR closed 2 years ago

BridgeAR commented 6 years ago

Right now all stacks can have a single type such as cpp, core, init etc. Sadly, it's only possible to add a single type instead of multiple ones. However, in a couple of cases multiple types could apply to a single stack.

It does seem to require a good portion of rewriting internal logic to change this tough. If there's a simple way to achieve this, please let me know.

mcollina commented 6 years ago

Can we document such cases?

BridgeAR commented 6 years ago

You mean documenting in what cases this could apply? E.g., v8 and cpp. init and core...

mcollina commented 6 years ago

Let's say we have a hierarchy for now if more apply:

init > v8 > cpp > core

BridgeAR commented 6 years ago

We have such a hierarchy at the moment. And it is exactly as you want this order.

mcollina commented 6 years ago

Oh, ok :D.

github-actions[bot] commented 2 years ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] commented 2 years ago

This issue was closed because it has been stalled for 5 days with no activity.