search

davidmarkclements / 0x

🔥 single-command flamegraph profiling 🔥
MIT License
3.23k stars 106 forks source link

Fixed support for Node 8.12.0. #172

Closed mcollina closed 6 years ago

mcollina commented 6 years ago

PTAL

mcollina commented 6 years ago

Those lines cause the processor to fail, and we silence that error. I think this is just avoid future problems.

zbjornson commented 6 years ago

@mcollina this doesn't seem to always fix the problem -- I'm still getting the error with lines > 1024 characters removed. Maybe something else besides long lines causes printErr to be invoked?

My workaround was to evaluate https://github.com/nodejs/node/blob/2ae98ce7cb95dee79e839afb2ee4c7d77d7670cd/lib/internal/v8_prof_processor.js in a new JS file, and the errors that were logged were all Code move event for unknown code: 0xxxxxxxxxxx.

mcollina commented 6 years ago

Can you upload an example to reproduce? Thanks!

Il giorno mer 17 ott 2018 alle 04:00 Zach Bjornson notifications@github.com ha scritto:

@mcollina https://github.com/mcollina this doesn't seem to always fix the problem -- I'm still getting the error with lines > 1024 characters removed. Maybe something else besides long lines causes printErr to be invoked?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/davidmarkclements/0x/pull/172#issuecomment-430462489, or mute the thread https://github.com/notifications/unsubscribe-auth/AADL48cCIzKlM6difeCY9CTbgXgEhtQ7ks5ulo8qgaJpZM4WwD5Q .

zbjornson commented 6 years ago

Here's one: isolate-0x3aad0c0-v8.log