davidmarkclements / 0x

🔥 single-command flamegraph profiling 🔥
MIT License
3.23k stars 106 forks source link

error on Windows #202

Closed mcollina closed 2 years ago

mcollina commented 5 years ago
Error: Encountered an unparseable frame "(anonymous) D:\a
AlanSl commented 5 years ago

Can you post the full file / directory path (what's being chopped after the a) and I'll add it to the edge cases / tests PR I'm working on, which includes a lot of funky stuff with Windows paths, Unicode etc

AlanSl commented 5 years ago

Also which version of Node? The fix for Windows path separators being treated as escape patterns has some issues in Node 8 and different issues in Node 11 that aren't in Node 10

davidmarkclements commented 5 years ago

I spoke to @mcollina just now – it's Node 10 (and Windows 10)

if it's in the latest 0x release, https://github.com/davidmarkclements/0x/pull/201 might be related

mcollina commented 5 years ago

I think the regexp introduced in https://github.com/davidmarkclements/0x/pull/193/

is not complete/broken on Node 10.

cc @mafintosh

mcollina commented 5 years ago

I think this line https://github.com/davidmarkclements/0x/blob/1cfbc5686c8f8cc48bc500a8d31a7c61f00d770a/lib/v8-log-to-ticks.js#L36

needs to change the pattern from :\\ to :\

AlanSl commented 5 years ago

There's a bunch of issues with that regex that are fixed in the PR I'm working on, for instance it gets confused by unicode chars like //u12a3 - but in my tests I've only seen that happen on Node 8. What's the text after the a in your path?

Maybe it's mistakenly parsing something like D:/a/n as a newline?

mcollina commented 5 years ago

That happens on Azure pipelines. There is nothing else.

davidmarkclements commented 4 years ago

was this ever resolved?

github-actions[bot] commented 2 years ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] commented 2 years ago

This issue was closed because it has been stalled for 5 days with no activity.