fix: error msg on workingdir

davidmarkclements / 0x

🔥 single-command flamegraph profiling 🔥

MIT License

3.21k stars 103 forks source link

fix: error msg on workingdir #232

Closed ovhemert closed 4 years ago

ovhemert commented 4 years ago

When using the API, and specifying a different workingDir, the process crashes with the following error:

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received type undefined

It was originally reported in issue #228 and and fixed in PR #229 but a test is still missing to get it merged. This PR applies the same fix, and adds a test to validate the error does not occur anymore.

ovhemert commented 4 years ago

seems to fail on CI somehow => WIP

mcollina commented 4 years ago

Is this still a wip?

ovhemert commented 4 years ago

Nope... working now. Forgot to remove WIP i guess