linux: fixes perf profiling stacktraces

davidmarkclements / 0x

🔥 single-command flamegraph profiling 🔥

MIT License

3.21k stars 103 forks source link

linux: fixes perf profiling stacktraces #244

Closed RafaelGSS closed 2 years ago

RafaelGSS commented 2 years ago

Address: #242

This PR also adds support to categorization through perf stack traces.

RafaelGSS commented 2 years ago

Quick feedback. I'm still working in the PR because it's missing:

A better parser of functions with categories (CPP, V8, JS)

Inlined functions

RafaelGSS commented 2 years ago

While I look into how to test those changes, this PR is ready to review.

Also, is missing the inlined functions, I'm looking into V8 options to see how inlined functions act when --perf-basic-prof is passed. Otherwise, I'm thinking in to use --print-opt-source along with perf traces to track it down.

RafaelGSS commented 2 years ago

The 0x now creates a flamegraph like this one:

(It was not even generated in the master version)

Also, notice that ^etag.js and etag.js are considered different stack-line, someone knows why?