search

davidmarkclements / 0x

🔥 single-command flamegraph profiling 🔥
MIT License
3.21k stars 103 forks source link

Support `.cpuprofile` of `node --cpu-prof` #256

Closed kazarmy closed 2 years ago

kazarmy commented 2 years ago

This pr adds support for the .cpuprofile file generated by node --cpu-prof, which is actually slightly different in format compared to the one generated by v8-profiler-next (an example is provided here as part of the pr). An example of node --cpu-prof invocation has been added as part of examples/cpu-profiler/test.sh where it is used to profile autocannon.

kazarmy commented 2 years ago

Fixes #215.

kazarmy commented 2 years ago

merge?

mcollina commented 2 years ago

Seems the linting is failing: https://github.com/davidmarkclements/0x/runs/6844137924?check_suite_focus=true#step:5:16

kazarmy commented 2 years ago

Ok fixed (6f3aefce32f43f6537074b89831249454f7f9dd4). I'm also now running the linter locally so there shouldn't be any linter errors after this.

kazarmy commented 2 years ago

merge now?

kazarmy commented 2 years ago

thx!