search

davidmarkclements / cute-stack

Cute up your stack traces in Node
82 stars 6 forks source link

should plugins have control over stack trace limit #7

Closed davidmarkclements closed 9 years ago

davidmarkclements commented 9 years ago

we should probably have a way for plugins to set their own stack trace limit defaults, different use cases may call for different limits

bahmutov commented 9 years ago

Plugins can use .filter method to limit output

Sent from my iPhone

On Feb 12, 2015, at 10:04 AM, davidmarkclements notifications@github.com wrote:

we should probably have a way for plugins to set their own stack trace limit defaults, different use cases may call for different limits

— Reply to this email directly or view it on GitHub.

davidmarkclements commented 9 years ago

but not increase it - unless it edits Error.stackTraceLimit directly

this raises the question should we just be done with it and set Error.stackTraceLimit to Infinity then .filter can limit it (which still seems a little raw) or keep it at node's default of 10 but allow plugins to set their own defaults via cute stack

bahmutov commented 9 years ago

I would not allow plugins to set the limit - mainly because the user probably knows better, that is why it is the second argument to cute-stack

davidmarkclements commented 9 years ago

ok yah leave as config option - good call