search

davidmarkclements / fast-redact

very fast object redaction
MIT License
278 stars 30 forks source link

chore: add files to npmignore #21

Closed maximelkin closed 4 years ago

maximelkin commented 4 years ago

This should reduce size of published package from 136k to 60k

davidmarkclements commented 4 years ago

thanks for the PR - I don't agree with the premise that reducing install size by less than half the size of an 8 inch floppy disk (Memorex 650 had 175kb) is worth removing examples and tests from any module. If used in the frontend, these parts of the package would have no effect on payload size and in the backend it matters so little as to be insignificant. Examples and tests can be quick offline references within the node_modules folder, so the tradeoff makes no sense to me.

maximelkin commented 4 years ago

Okay, sorry for bothering