Closed lrecknagel closed 2 years ago
Can you also rebase on top of main so we get some CI running? Thanks!
Thanks for the hints and comments! I´ve working on the benchmark part and will push it asap.
001_fast-redact-bench-main.txt 002_fast-redact-bench-wc_finalization.txt
Depending on getObj
which gives a relatively flat object it might be interesting to add another multi-wc bench on deeper nested objects. Would be great if you could express your opinion on that shortly.
I'm good with the benchmarks I'm seeing
thanks @lrecknagel - it all seems good to me, I think let's get this merged, any extra benchmarks that could be PR'd after are always welcome but not demanded
First - thanks for all the efforts already put in this project and also the PR with I`am picking up!
2nd - I hope I have picked up the prior work correctly, please tell me if I take a wrong path here. (Followed the suggested manual: https://gist.github.com/jsumners/461ef7a64545108635cc437fde112721)
I´ve worked on finishing the multi-wildcard feature #36 with the missing test-coverage. Also added handling for a
undefined / null
case which I`ve found.Following checks have been made:
npm run cov-ui
npm run test
npm run bench
(see attached report)fast-redact-bench-wc_finalization.txt
Please give me ping if I forgot something - hope we can bring this feature to life!
Best Lucas