fix: support IE8 further

davidmarkclements / fast-safe-stringify

Safely and quickly serialize JavaScript objects

MIT License

348 stars 27 forks source link

Closed BridgeAR closed 6 years ago

BridgeAR commented 6 years ago

I personally think it is a bad idea to support this but since it worked before it was a mistake to break this in the last minor.

mcollina commented 6 years ago

I think we can leave Object.keys(). However, one might be faster than the other.. http://benediktmeurer.de/2017/09/07/restoring-for-in-peak-performance/

BridgeAR commented 6 years ago

@mcollina yes, there is a small performance difference but it should not be very significant.

About leaving Object.keys - that was removed in #18 (November 2017).

mcollina commented 6 years ago

Damn