davidmarkclements / rfdc

Really Fast Deep Clone
MIT License
635 stars 24 forks source link

Add import of default clone function #15

Closed NearW closed 4 years ago

NearW commented 4 years ago

This PR implements the option of a default clone import with a nicer syntax as described in #14

codecov[bot] commented 4 years ago

Codecov Report

Merging #15 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #15   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         2    +1     
  Lines           96        97    +1     
=========================================
+ Hits            96        97    +1     
Impacted Files Coverage Δ
default.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9895efb...125d8ae. Read the comment docs.

NearW commented 4 years ago

Thanks @BridgeAR . I hope this revision does the work now. :)

BridgeAR commented 4 years ago

@davidmarkclements PTAL

NearW commented 4 years ago

Looking at this again: please add a simple test case as well.

Done. I'm not familiar with how the types in tap work, so please hit me up if I forgot anything. :)

BridgeAR commented 4 years ago

@NearW that looks fine, thanks. Before I'll merge this, would you please also add a minimal documentation? I missed that before :-)

NearW commented 4 years ago

@NearW that looks fine, thanks. Before I'll merge this, would you please also add a minimal documentation? I missed that before :-)

That's a good point! Done. :)

BridgeAR commented 4 years ago

Thanks a lot!