search

davidmarkclements / screenres

Get and set screen resolutions
Other
20 stars 12 forks source link

Updated the dependencies #5

Closed IonicaBizau closed 8 years ago

IonicaBizau commented 8 years ago

A first try to fix #4–not a real fix, but this upgrades the dependencies versions and it's still working on v0.12.6. :grin:

Actually it's fixing #4. I ported the C++ file too. :smile:

IonicaBizau commented 8 years ago

/cc @davidmarkclements :bell: :grinning: I know you are busy, but I need this to be fixed.

IonicaBizau commented 8 years ago

@davidmarkclements Can you please take a look here?

davidmarkclements commented 8 years ago

@ionicabizau Dude you're awesome - so sorry for inattention I'm going to have to split up my firehose of github notifications to get better visibility - I will check this out in the next 30mins merge and publish as long as no conflicts

davidmarkclements commented 8 years ago

Just started reviewing :)

:octocat: Sent from GH.

IonicaBizau commented 8 years ago

@davidmarkclements Oh, nice! :star:

davidmarkclements commented 8 years ago

this is what I'm getting in 0.12.17 when attempting to get or set

dyld: lazy symbol binding failed: Symbol not found: _CGMainDisplayID
  Referenced from: /Users/davidclements/z/nearForm/screenres/build/Release/screenres.node
  Expected in: dynamic lookup

dyld: Symbol not found: _CGMainDisplayID
  Referenced from: /Users/davidclements/z/nearForm/screenres/build/Release/screenres.node
  Expected in: dynamic lookup

Trace/BPT trap: 5
davidmarkclements commented 8 years ago

and when attempting to build on 4.1.2 I get

  CXX(target) Release/obj.target/screenres/linux.o
  CXX(target) Release/obj.target/screenres/osx.o
../osx.cc:29:16: error: type 'CGFloat' (aka 'double') cannot be narrowed to
      'int' in initializer list [-Wc++11-narrowing]
      .width = screenSize.width,
               ^~~~~~~~~~~~~~~~
../osx.cc:29:16: note: override this message by inserting an explicit cast
      .width = screenSize.width,
               ^~~~~~~~~~~~~~~~
               static_cast<int>( )
../osx.cc:30:17: error: type 'CGFloat' (aka 'double') cannot be narrowed to
      'int' in initializer list [-Wc++11-narrowing]
      .height = screenSize.height
                ^~~~~~~~~~~~~~~~~
../osx.cc:30:17: note: override this message by inserting an explicit cast
      .height = screenSize.height
                ^~~~~~~~~~~~~~~~~
                static_cast<int>()
davidmarkclements commented 8 years ago

what version of OS X are you running?

IonicaBizau commented 8 years ago

@davidmarkclements Hmm, it compiles successfully on these versions for me (I'm using nvm). I am using Ubuntu 15.10.

davidmarkclements commented 8 years ago

oh I see you're using the linux bindings

ok so it's broken on OS X but for other reasons.

ok.. best thing to do here I think is to make this a branch for now till we have OS X covered

then we can publish with next dist tag

npm i screenres@next

So I don't keep blocking you I've made you a collab on both gh and npm

davidmarkclements commented 8 years ago

done

npm i screenres@next

for node 0.12.x and node 4.x.x support on Linux - OS X todo

IonicaBizau commented 8 years ago

@davidmarkclements Thanks for adding me collaborator here! :smile: I was using my fork, so it's not really a blocking thing:

{
     "screenres": "IonicaBizauKitchen/screenres#updated-dependencies"
}

But having this next tag is handy too.