translateFromPrimitive uses Float for character and byte

davidmarquis / fluent-interface-proxy

Forget boiler plate code for your Java Fluent builders! This project provides a proxy that implements your Builder interfaces dynamically (no code required!)

MIT License

55 stars 17 forks source link

translateFromPrimitive uses Float for character and byte #2

Closed Sardtok closed 10 years ago

Sardtok commented 10 years ago

I'm not sure if this is intentional or if this is a bug, but this looks to me like a copy-paste error. I know that one could convert 16 and 8 bit integer values to float and vice versa, but shouldn't the java.lang.Character and java.lang.Byte classes be used?

https://github.com/davidmarquis/fluent-interface-proxy/blob/4468befcbd7db765332d45e56e958daea59414b8/src/main/java/com/fluentinterface/proxy/BuilderProxy.java#L159-L162

davidmarquis commented 10 years ago

Indeed! I'll change that, unless you tell me you have a pull request ready

davidmarquis commented 10 years ago

Fixed by commit efdd9c5743062d8b39d615b622763531ef0a6028