search

davidmartos96 / sqflite_sqlcipher

SQLite flutter plugin
BSD 2-Clause "Simplified" License
102 stars 46 forks source link

Fix crash when normal sqflite is being used #30

Closed daohoangson closed 3 years ago

daohoangson commented 3 years ago

Related to #19.

After #31 is merged, we can switch back the URL for fmdb_override in pubspec.

davidmartos96 commented 3 years ago

@daohoangson Oh thanks a lot for the contribution! I'll try to give this a try later and merge it :smile:

davidmartos96 commented 3 years ago

@daohoangson Is the renaming necessary? Or is it just to avoid a warning? If it is not really necessary I think leaving the original name would be better because merges from upstream sqflite would be easier.

daohoangson commented 3 years ago

The behavior is undefined when two methods have the same signature so I think we should rename.

The example works without the rename though. It's your call, I can revert the rename if you want.

davidmartos96 commented 3 years ago

Thanks for explaining. It would be better to keep the rename then. Just in case.

davidmartos96 commented 3 years ago

@daohoangson Sorry for the delay. I didn't have access to a macOS until now. All it's working perfectly. Thanks again for the contribution!!