search

davidmbillie / Hot-Potato

ASP.NET Core proxy that will validate an API's conformance to an OpenAPI spec.
MIT No Attribution
6 stars 1 forks source link

Use a fallback controller instead of a middleware #7

Closed lambchop4prez closed 1 year ago

lambchop4prez commented 1 year ago

As I mentioned in #5 we kinda misunderstood the purpose of the Middleware layer. This is my attempt at converting HotPotatoMiddleware into a Controller.

I based this on the changes from #4 so it's a bit busy to look at, but if you look for HotPotatoController.cs and Startup.cs, those are the changes I'm proposing.

davidmbillie commented 1 year ago

@lambchop4prez Would you be able to give me access rights to your fork? I tried to checkout your branch locally for some exploratory testing and got a "Permission denied" issue when I ran

git remote add lambchop4prez git@github.com:lambchop4prez/hot-potato.git git fetch lambchop4prez

lambchop4prez commented 1 year ago

@davidmbillie I added you as a Collaborator on my repo, I hope that works. If not let me know.

davidmbillie commented 1 year ago

@lambchop4prez It worked, thank you! It still wasn't working, but then it clicked that git@github.com was for ssh. I did the https way of git remote add lambchop4prez https://github.com/lambchop4prez/Hot-Potato.git, and it worked.

davidmbillie commented 1 year ago

@lambchop4prez Mind if I merge our recent main changes into this if you haven't already?