search

davidmeen / TomeOfTeleportation

Warcraft addon that allows easy access to teleportation spells and items.
7 stars 5 forks source link

[F] [#37] Hide spell prefixes not working #38

Closed ChesterYue closed 4 months ago

ChesterYue commented 4 months ago

I didn't write lua before.

Wondering why alwaysShowSpells can use as bool type, but the hidePrefixes need to compare with 1?
Some special lua syntax? Or some issue left over by history?

I didn't write wow addon before.

I try to test this modified line in my addon folder. Then /reload in game. It seem works.

Thanks for this addon.

ChesterYue commented 4 months ago

The order of https://github.com/davidmeen/TomeOfTeleportation/blob/cb1177dc26fc79d167a53aa32f5b3904c250e744/TeleporterSpell.lua#L8-L37 need to be changed.

If there is a spell called "Senda de las XX". And "Senda de " is before "Senda de las ", the cleanup name goes to "las XX".

davidmeen commented 4 months ago

I fixed this before I saw the pull request, so closing without merging. Thanks for reporting this.