Add support for W3 modal accessibility guidelines

davidmfoley / react-router-modal

Simple modals for react-router 4

MIT License

153 stars 20 forks source link

Add support for W3 modal accessibility guidelines #20

Closed Leapfrognz closed 5 years ago

Leapfrognz commented 6 years ago

Improve accessibility of the modal as per https://www.w3.org/TR/wai-aria-practices-1.1/#dialog_modal or, allow us to define custom markup which should help with things like adding aria-modal="true" to the container

davidmfoley commented 5 years ago

@Leapfrognz v1.5.0 has support for: role (defaults to dialog, can be overridden to alertdialog) aria-modal (always set to true) aria-* (when set on Modal, ModalRoute, ModalLink, are rendered on the modal div)

davidmfoley commented 5 years ago

Sorry this took six months for me to get to. Let me know if there are other improvements to make here for your use case -- I'd be happy to put in some more work here. Thanks.