search

davidmfoley / react-router-modal

Simple modals for react-router 4
MIT License
153 stars 20 forks source link

Not visible on small screens #40

Open etairi opened 5 years ago

etairi commented 5 years ago

I'm using react-router-modal in my project, and so far it seems to work fine everywhere I tested. Except it doesn't seem to work on Safari in iOS12. Please note that I did not test it with earlier versions of iOS or with a MacOS. The component that I have given to ModalRoute includes text fields, and basically the text fields are present there, but nothing is visible.

davidmfoley commented 5 years ago

Thanks for the report. Do you experience the same behavior on other small screens?

davidmfoley commented 5 years ago

Thanks for the info. I'll try to take a look this weekend. Is your project in a public place where I can try it out? Thanks.

etairi commented 5 years ago

I just tested it with iPhone 6S using Safari, Chrome and Firefox, and it is the same behavior. So it seems to be a problem related to small screens.

You can test it from this link: https://dev.smorder.at/web/login

etairi commented 5 years ago

Btw, we are using version ^2.0.0-rc2.

moparlakci commented 5 years ago

Same here on my Ipad.. I think there is a CSS (transform) problem. Couldn't figure it out. Waiting to here from you.

khronos90 commented 5 years ago

This is the fixed I used for this

@media only screen and (max-device-width: 1024px) { .react-router-modal__modal-open { position: inherit !important; } }