search

davidmiller / pony-mode

Django mode for emacs
Other
149 stars 32 forks source link

Remove bundled ert.el #99

Closed tarsius closed 7 years ago

tarsius commented 7 years ago

Ert was added to GNU Emacs in version 24.1, which was released in

  1. Bundling a built-in or third-part library should generally be avoided because the bundled version might end up being loaded for users who also have a more recent version installed.
tarsius commented 7 years ago

When I first opened this pr could not be run travis because an unreasonably old Emacs version was used there and because pip was used in a way that no longer works. After fixing these issues the tests did run again but now the tests revealed an unrelated bug in your code. I have fixed that too.

davidmiller commented 7 years ago

Thanks @tarsius !

tarsius commented 7 years ago

You are welcome! Thanks for merging.