Start testing Normalizr

davidmogar / cucco

Text normalization library for Python

MIT License

203 stars 27 forks source link

Start testing Normalizr #10

Closed benfei closed 7 years ago

benfei commented 8 years ago

New test/ dir was added, with some basic tests in it.

New tests:

basic tests of URL_REGEX, EMAIL_REGEX.
more tests can be easily add using the same pattern.

It's suggested to start using continuous integration. A basic config file for TravisCI is also included.

davidmogar commented 8 years ago

Great PR @feinsteinben,

I'll accept it for sure but I'll wait for #8 so normalizr can have support for Python 2. I also have a couple of comments for your other PR that I'll write eventually ^^

Thank you, David

davidmogar commented 8 years ago

As I commented in #9 would be nice if you can change the format of your commit messages. Me and my OCD :wink:

benfei commented 8 years ago

Fixed it :-)

benfei commented 7 years ago

Added several more tests. @davidmogar

benfei commented 7 years ago

Hi @davidmogar ,

I found a wrong test-case and fixed it. The fixed commit is in the same branch as the pull-request.

Sorry for the trouble, Ben.

davidmogar commented 7 years ago

Yeah, I suppose it's the one I wrote in #16. I fixed on my local branch. I'll push it now. Otherwise you would have to open a new pull request as this one is already closed ;)