search

davidmoreno / onion

C library to create simple HTTP servers and Web Applications.
http://www.coralbits.com/libonion/
Other
2.02k stars 252 forks source link

Only add_subdirectory(tests) for ONION_USE_TESTS #231

Closed jeffvandyke closed 6 years ago

jeffvandyke commented 6 years ago

This allows users of this project that incorporate it into their CMake buildsystem to optionally avoid needing to compile the tests for a clean build. If tests aren't run, then (maybe I'm wrong) I don't see a need to compile them.

davidmoreno commented 6 years ago

Maybe we should also enable tests by default (so just flip the ONION_USE_TEST to default true at the beginning of file).

What do you think?

jeffvandyke commented 6 years ago

Just finished testing it, and that should work fine, and it makes sense if by default we're compiling the examples as well.

davidmoreno commented 6 years ago

Looks cool, but I see test are failing now. I will try to fix it today before merging this pull request.

davidmoreno commented 6 years ago

Sorry, took me some days to be able to look into it. All passing now on my laptop.

There was only one problem on the websocket test running because of a compile time requirement.

jeffvandyke commented 6 years ago

No problem, you're doing pretty good for time compared to some of the other projects I've seen :smile: