adding C++ Onion::Request::Method_Name

davidmoreno / onion

C library to create simple HTTP servers and Web Applications.

http://www.coralbits.com/libonion/

Other

2.01k stars 250 forks source link

adding C++ Onion::Request::Method_Name #292

Closed bstarynk closed 3 years ago

bstarynk commented 3 years ago

This patch adds a C++ binding to onion_request_get_method_name. Such a patch could be useful to the RefPerSys project.

In my opinion, ONION_VERSION_MINOR should also be incremented to reflect this API improvement, but I don't know how to do that.

Regards from Basile Starynkevitch (near Paris, in France). Email me to basile@starynkevitch.net if needed.

davidmoreno commented 3 years ago

Name of the method should be methodName to follow the style of the other C++ methods.

I will look into increasing the minor number once the patch is accepted, but just for only one small change there may be no need... if we have several of those, then right, new release. We are developing on master, no need to create new releases for each small increment.. but I'm not opposed neither.

bstarynk commented 3 years ago

I renamed it per your suggestion. Thanks for the review