search

davidmoten / openapi-codegen

OpenAPI Java client and Spring server generator, strong typing, immutability, fail-fast validation, chained builders, feature rich
Apache License 2.0
8 stars 1 forks source link

combine validation checks under one if statement in ServiceController methods #61

Closed davidmoten closed 1 year ago

davidmoten commented 1 year ago

No functional change, just neatens up the generated ServiceController parameter validation in service methods.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 30.55% and project coverage change: +0.01% :tada:

Comparison is base (8e2a4fe) 79.62% compared to head (6643196) 79.64%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #61 +/- ## ============================================ + Coverage 79.62% 79.64% +0.01% Complexity 837 837 ============================================ Files 42 42 Lines 2965 2967 +2 Branches 442 443 +1 ============================================ + Hits 2361 2363 +2 Misses 445 445 Partials 159 159 ``` | [Files Changed](https://app.codecov.io/gh/davidmoten/openapi-codegen/pull/61?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Dave+Moten) | Coverage Δ | | |---|---|---| | [...n/generator/writer/ServerCodeWriterSpringBoot.java](https://app.codecov.io/gh/davidmoten/openapi-codegen/pull/61?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Dave+Moten#diff-b3BlbmFwaS1jb2RlZ2VuLWdlbmVyYXRvci9zcmMvbWFpbi9qYXZhL29yZy9kYXZpZG1vdGVuL29hMy9jb2RlZ2VuL2dlbmVyYXRvci93cml0ZXIvU2VydmVyQ29kZVdyaXRlclNwcmluZ0Jvb3QuamF2YQ==) | `83.25% <30.55%> (+0.14%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.