Closed davidmoten closed 4 years ago
Merging #34 into master will decrease coverage by
0.06%
. The diff coverage is81.96%
.
@@ Coverage Diff @@
## master #34 +/- ##
============================================
- Coverage 68.74% 68.68% -0.07%
- Complexity 417 427 +10
============================================
Files 69 69
Lines 3558 3602 +44
Branches 390 402 +12
============================================
+ Hits 2446 2474 +28
- Misses 988 996 +8
- Partials 124 132 +8
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a91d2ba...9912682. Read the comment docs.
Add
Transformers.split(maxItemLength, pattern, maxPatternLength)
operator.This is a useful operator in the circumstance that the input is not neccessarily controlled and there exists the possibility of a really long stream of strings arriving without a delimiter. This may cause the normal split operator to throw an OutOfMemoryException as it accumulates a really long string waiting for the delimiter.
Unit test coverage of new operator is complete but for some
isUnsubscribed()
checks. These are painful to write tests for because buffering is occurring in the state-machine operator so I've left them out.See javadoc of new operator for more detail.
In theory there is extra allocation overhead using this operator but benchmarks show no significant difference.