search

davidmoten / subethasmtp

SubEtha SMTP is a Java library for receiving SMTP mail
Other
141 stars 38 forks source link

don't error on empty username or password #105

Closed martijnhoekstra closed 1 year ago

martijnhoekstra commented 1 year ago

prevent NoSuchElementException

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.24 :tada:

Comparison is base (13e0a7f) 70.41% compared to head (e9a8234) 70.65%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #105 +/- ## ============================================ + Coverage 70.41% 70.65% +0.24% - Complexity 460 461 +1 ============================================ Files 72 72 Lines 2373 2372 -1 Branches 250 250 ============================================ + Hits 1671 1676 +5 + Misses 581 575 -6 Partials 121 121 ``` | [Impacted Files](https://app.codecov.io/gh/davidmoten/subethasmtp/pull/105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Dave+Moten) | Coverage Δ | | |---|---|---| | [...l/smtp/auth/LoginAuthenticationHandlerFactory.java](https://app.codecov.io/gh/davidmoten/subethasmtp/pull/105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Dave+Moten#diff-c3JjL21haW4vamF2YS9vcmcvc3ViZXRoYW1haWwvc210cC9hdXRoL0xvZ2luQXV0aGVudGljYXRpb25IYW5kbGVyRmFjdG9yeS5qYXZh) | `64.28% <100.00%> (+3.82%)` | :arrow_up: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/davidmoten/subethasmtp/pull/105/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Dave+Moten)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

davidmoten commented 1 year ago

Thanks very much @martijnhoekstra!