search

davidmoten / subethasmtp

SubEtha SMTP is a Java library for receiving SMTP mail
Other
149 stars 40 forks source link

Upgrade Jakarta Mail 2.1 dependencies #124

Closed rtaugerbeck closed 9 months ago

rtaugerbeck commented 9 months ago
codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e4c24f4) 70.92% compared to head (92df67e) 70.92%. Report is 5 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #124 +/- ## ========================================= Coverage 70.92% 70.92% Complexity 463 463 ========================================= Files 72 72 Lines 2373 2373 Branches 248 248 ========================================= Hits 1683 1683 Misses 572 572 Partials 118 118 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bbottema commented 8 months ago

When are you releasing a version with this update? This library is currently blocking me from upgrading Simple Java Mail to Angus Mail.

davidmoten commented 8 months ago

Shouldn't be a blocker I thought. Just exclude old and include new?

bbottema commented 8 months ago

That depends if you used classes from the implementation (now Angus), because the group and package names changed.

However, since it's a test dependency it turned out not to be an issue anyway. But still, I prefer not to have multiple java mailing frameworks on my classpath.

Do you have a release date in mind?

davidmoten commented 8 months ago

Ah this is merged already. Yep I'll build a release today.

davidmoten commented 8 months ago

7.0.1 on Maven Central now

bbottema commented 8 months ago

Thanks!