PlainAuthenticationHandlerFactory doesn't detect invalid Base64 string

davidmoten / subethasmtp

SubEtha SMTP is a Java library for receiving SMTP mail

Other

153 stars 40 forks source link

PlainAuthenticationHandlerFactory doesn't detect invalid Base64 string #140

Open teemulang opened 3 weeks ago

teemulang commented 3 weeks ago

PlainAuthenticationHandlerFactory expects Base64.getDecoder().decode(secret) to return null on failure, but actually an IllegalArgumentException is thrown. LoginAuthenticationHandlerFactory handles this correctly.

davidmoten commented 3 weeks ago

Thanks! I'll have a look