Replace dependency com.sun.mail:jakarta.mail by jakarta.mail:jakarta.mail-api

davidmoten / subethasmtp

SubEtha SMTP is a Java library for receiving SMTP mail

Other

149 stars 40 forks source link

Replace dependency com.sun.mail:jakarta.mail by jakarta.mail:jakarta.mail-api #89

Closed ghusta closed 1 year ago

ghusta commented 1 year ago

I saw subethasmtp was upgraded to Jakarta Mail 2.0 in https://github.com/davidmoten/subethasmtp/pull/37.

Maybe the dependency com.sun.mail:jakarta.mail could also be replaced by the more recent jakarta.mail:jakarta.mail-api, which is equivalent, and actively maintained ?

ghusta commented 1 year ago

⚠️ However it may not be a good idea, as classes in com.sun.mail.* are not present in jakarta.mail-api, but only in jakarta.mail...

See for example :

https://stackoverflow.com/questions/16807758/java-lang-noclassdeffounderror-com-sun-mail-util-maillogger-for-junit-test-case

davidmoten commented 1 year ago

ok, thanks for having a look at it. I don't see an advantage to including the mail api dep and an implementation for the moment. Happy to discuss further. I'll close the issue but feel free to reopen if there's more to say.

ghusta commented 1 year ago

Yes you're right, it's better to let it like this for the moment. Thank you.