search

davidmpye / RT73-utils

GNU General Public License v3.0
3 stars 2 forks source link

Alarm and Prompt fields of channel info elements address the same bit. #7

Open hmatuschek opened 2 years ago

hmatuschek commented 2 years ago

I've just started to implement the RT73 support for qdmr and I noticed that these two fields address the same bit. That is,

https://github.com/davidmpye/RT73-utils/blob/9f63402de831328bd1eb1425e91120f28a0025d8/rt73.py#L487

and

https://github.com/davidmpye/RT73-utils/blob/9f63402de831328bd1eb1425e91120f28a0025d8/rt73.py#L488

DavidB445 commented 2 years ago

Line 488 should be as below. Note its listed in the channel edit menu on the radio as "CallAlert"

channel_info["Prompt"] = [ "Bitmask", 0x14, 0x04 , { 0x00: "OFF", 0x04: "ON" } ]
davidmpye commented 2 years ago

Oops, I'll fix that - thanks both!

On Tue, 4 Jan 2022 at 01:19, DavidB445 @.***> wrote:

Line 488 should be as below. Note its listed in the radio channel edit menu as "CallAlert"

channel_info["Prompt"] = [ "Bitmask", 0x14, 0x04 , { 0x00: "OFF", 0x04: "ON" } ]

— Reply to this email directly, view it on GitHub https://github.com/davidmpye/RT73-utils/issues/7#issuecomment-1004462177, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARIHYPSOSZHQ63NG225JPDUUJDILANCNFSM5LE3PHQA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

hmatuschek commented 2 years ago

Ok, thanks.