davidmpye / V10_Dyson_BMS

A reworked unofficial firmware for Dyson V10 Battery Management Systems
GNU General Public License v3.0
56 stars 15 forks source link

Is there a watchdog in the code? #13

Open turenabo opened 5 months ago

turenabo commented 5 months ago

hi David, I read your code and didn't see a watchdog. I don't know if your program has a watchdog? If not, will it cause battery danger in case of system down? And I see the battery management chip has some automatic protection functions, this should enhance security. It shouldn't take long for this vacuum cleaner to wake up and go back to sleep again, so the probability of it's down during this period shouldn't be high, right?

davidmpye commented 3 months ago

Good question - there is no watchdog.

There SHOULDNT be a large risk because if the code somehow crashed, the battery management IC will automatically 'trip' and disconnect the power (or the charging) if there is a fault, even if the MCU is not working.

If you'dl like to implement a watchdog, pull requests welcome :-)