search

davidmroth / stm32flash

Automatically exported from code.google.com/p/stm32flash
0 stars 0 forks source link

Release builds do not work #35

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Build software in release mode causes code within assert() macros to be removed 
by the pre-processor. Since we are doing actual work, not just checking 
parameters in these macros, release builds don't work

Original issue reported on code.google.com by reubendowle0@gmail.com on 23 Nov 2012 at 12:52

GoogleCodeExporter commented 9 years ago 
See attached patch against git master which addresses this issue

Original comment by reubendowle0@gmail.com on 23 Nov 2012 at 1:09

Attachments:

GoogleCodeExporter commented 9 years ago 
Thanks! This makes so much sense. Not only is it wrong to do things inside the 
assert macro, an assert should only be used to trap programming errors and 
generate a core dump or stack trace, and not to validate user data. Applied it 
to my merging branch.

Original comment by lists.to...@gmail.com on 24 Nov 2012 at 1:30

GoogleCodeExporter commented 9 years ago 
This has now been fixed in the official repository and is included in version 
0.3beta2.

Original comment by lists.to...@gmail.com on 9 Dec 2013 at 11:17