search

davidmwine / gitinspector

Automatically exported from code.google.com/p/gitinspector
GNU General Public License v3.0
0 stars 0 forks source link

Translation to Korean #51

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
I have translated message.pot to message_ko.po
Please Check this.
It has not yet 100%, I'll update remaining soon.
And, this requires some code changes
in the gitinspector.py, I added

    reload(sys)
    sys.setdefaultencoding('utf-8') 

for Python 2 to treat unicode correctly.
So at the first, please review the modified code, too.

Original issue reported on code.google.com by yes...@gmail.com on 15 Dec 2014 at 5:26

Attachments:

GoogleCodeExporter commented 9 years ago 
Great! It's a good start.

Concerning the code change - it shouldn't be needed and is mostly considered 
bad practice. If you need to set the encoding because of a misconfigured 
terminal or similar, using the PYTHONIOENCODING env variable should work.

However, I did find a bug (related to unicode) in the localization.get_date() 
function when testing your Korean translation. Maybe that was triggering your 
problems? It has been fixed with revision eed6d0debf43.

I added you to the project as the translator for the Korean locale.

/Adam Waldenberg

Original comment by gitinspe...@ejwa.se on 18 Dec 2014 at 3:10

GoogleCodeExporter commented 9 years ago 
Thank you for adding me as the translator.
Your patch(revision eed6d0debf43) is working correctly. 
Without any other env. setting. it worked.
I'll delete my patch and will complete current translation upto this week.

And Question.
If I complete my translation, Should I commit with my hand?(I don't know 
permission)
Or you will add?

Original comment by yes...@gmail.com on 18 Dec 2014 at 3:32

GoogleCodeExporter commented 9 years ago 
Good to hear that it's working.

Just add the translation to this issue and I will commit it to the repository 
under your name.

Also, gitinspector now properly supports languages with multi-column characters 
when using the terminal output. See revision 568a5e5e8b31 for the fix. I 
thought it might be a good idea now that both Chinese and Korean are part of 
the supported translations.

/Adam Waldenberg

Original comment by gitinspe...@ejwa.se on 19 Dec 2014 at 2:08