search

davidmyersdev / vite-plugin-node-polyfills

A Vite plugin to polyfill Node's Core Modules for browser environments.
MIT License
301 stars 22 forks source link

chore: upgrade vite to v5 #57

Closed maxnowack closed 10 months ago

maxnowack commented 10 months ago

resolves #55

TomPlum commented 10 months ago

While updating the peer dependencies will fix the npm installation in consumers, don't we want to also bump the version of vite to v5 that the source is compiling and using? So the plugin is tested against the version its declaring its compatible with?

maxnowack commented 10 months ago

@TomPlum you're totally right. I've updated the PR

daiky00 commented 10 months ago

@TomPlum can you please review? I need this PR to get my stuff working

maxnowack commented 10 months ago

Hey @daiky00, please note that @TomPlum isn't responsible for managing this repository, so he can't merge your pull request. The only person with merge authority here is @davidmyersdev. However, repeatedly contacting him probably won't expedite the process. I'm sure he's already aware of the issue and he will look into it, when he has the time.

If you need a quick solution, consider forking the package or implementing the temporary fix suggested in issue #55. Persistently nudging others is unlikely to accelerate the resolution.

davidmyersdev commented 10 months ago

Hey, @maxnowack! Thanks so much for the PR. I want to make sure we're still testing other versions of Vite, so I'll likely need to modify this a bit after I merge it. That said, I'll try to get an initial release out today to fix the peer dependency and worry about supporting multiple versions after that.

maxnowack commented 10 months ago

@davidmyersdev thanks for merging!

davidmyersdev commented 10 months ago

No problem at all! 😄 This was released in v0.17.0.