search

davidnguyen11 / create-react-progressive-web-app

Simple demo of progressive web app. This demo will display the news of technology from API provided by https://newsapi.org/
60 stars 10 forks source link

Request to update React-Router V3 to V4 #4

Open jsk548 opened 7 years ago

jsk548 commented 7 years ago

Hi @nndung179, I have faced lot of issues while deploying to apache server. I kindly request you to update to v4 with BrowserRouter . And i want to run my project from subdirectory so we should use BrowserRouter's basename. I have tried but it is giving error.

Further more, here is what i found with your project setup i have deployed as - demo1.gd.com/cliq - (which serves the index) but i have fouind that when i click on products it should take me to demo1.gd.com/cliq/products instead it takes me to demo1.gd.com/products it is missing the cliq in the url - demo1.gd.com/cliq whch is the host

hope you make it soon. Thank You.

davidnguyen11 commented 7 years ago

Hi @jsk548 !!!

You may want to take a look at new version of create-react-app with many new features included PWA. There released new version. I will update the version of this repo soon.

jsk548 commented 7 years ago

Thanks @nndung179 , Your project setup is really awesome with Redux-saga. Waiting for your new version of repo.

davidnguyen11 commented 7 years ago

Hi @jsk548 !!!

I have upgrade version of create-react-app & other packages. But I still have some issue with react-router version 4. Still finding solution for this.

jsk548 commented 7 years ago

I have upgrade version of create-react-app & other packages

Good @nndung179 , please update here when you are done. this might be helpful for us https://reacttraining.com/react-router/web/api

jsk548 commented 7 years ago

Hi @nndung179 , any updates on this ?

jsk548 commented 7 years ago

Hi @nndung179 , is that React Router v4 working ?