search

davido / bucklets

Reusable building blocks for Buck build system. Please upload patches to this Gerrit project https://gerrit-review.googlesource.com/#/admin/projects/bucklets
Apache License 2.0
23 stars 1 forks source link

attach_source default causing problems on buck master #1

Open bootstraponline opened 10 years ago

bootstraponline commented 10 years ago

I had to set the attach_source to False in maven_jar.bucket, otherwise a bunch of these errors appear:

Caused by: java.util.concurrent.ExecutionException: java.io.FileNotFoundException: /training/modules/source/java_ios_2/buck-out/gen/lib/selenium/selenium-remote-driver/selenium-remote-driver-2.40.0-src.jar (No such file or directory) at com.google.common.util.concurrent.AbstractFuture$Sync.getValue(AbstractFuture.java:299) at com.google.common.util.concurrent.AbstractFuture$Sync.get(AbstractFuture.java:286) at com.google.common.util.concurrent.AbstractFuture.get(AbstractFuture.java:116) at com.google.common.util.concurrent.Uninterruptibles.getUninterruptibly(Uninterruptibles.java:135) at com.google.common.cache.LocalCache$Segment.getAndRecordStats(LocalCache.java:2344) at com.google.common.cache.LocalCache$Segment.loadSync(LocalCache.java:2316) at com.google.common.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2278) at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2193) at com.google.common.cache.LocalCache.get(LocalCache.java:3932) at com.google.common.cache.LocalCache.getOrLoad(LocalCache.java:3936) at com.google.common.cache.LocalCache$LocalLoadingCache.get(LocalCache.java:4806) at com.facebook.buck.util.DefaultFileHashCache.get(DefaultFileHashCache.java:74) ... 16 more

On an older buck version, I didn't see this issue.

davcamer commented 10 years ago

I just tried maven_jar as well. I get similar errors to the above, and then that executor runs forever. I have one that is sitting at 890s to download 'guava-16.0-src.jar'.

Same jar takes 0.3s after changing the attach_source default to False.

davido commented 10 years ago

Just to make sure: This repository was moved to gerrit-review [1]. Have you cloned it from there?

[1] git clone https://gerrit.googlesource.com/bucklets

davido commented 10 years ago

Added Warning to README and link to the right repository.

davido commented 10 years ago

Updated the Github repo with newest version: remove usage of genfile() as this is considered to be deprecated and going to be removed. PTAL.

davcamer commented 10 years ago

Thanks for the tip! Several blogs from around the time Gerrit's build process was switched to Buck point to this repo.

I tried the bucklets from the Gerrit repo, and that worked correctly.

Thank you for updating this repo as well. I tried the latest version from here, and it also worked correctly. Actually, it completed even a little bit more quickly (0.9s vs 3.0s), but that could be because of some caching I don't know about.

Any thoughts on which version is best to use for the future?

davido commented 10 years ago

I will keep this repo in sync with gerrit. And i think it's easy for hte folks report here issues. So i suggest to use this one. I am going to add even more bucklets like gwt_module() , gerrit_plugin() and set up Wiki with documentation and examples. Don't hesitate to help ;-)