davido / gerrit-oauth-provider

OAuth2 authentication provider for Gerrit Code Review. Please upload changes for review to: https://gerrit-review.googlesource.com/#/admin/projects/plugins/oauth
Apache License 2.0
140 stars 84 forks source link

Fixed Keycloak OIDC URL and BUILD #168

Closed cembas closed 1 year ago

cembas commented 1 year ago

The guide in BUILD did not work, so I changed the name in gerrit_plugin to 'oauth'. Then it worked.

The Keycloak URLs have changed, so I have fixed that as well. The output plugin file have been tested on the latest version of Gerrit and OIDC works fine now.

kschoenberger commented 1 year ago

Wanted to provide exactly the same! Thx @cembas.

@davido please merge and release a new version. Thanks

cembas commented 1 year ago

I'll see to it that it gets submitted there. Thanks!

davido commented 1 year ago

Sorry, I was OOO. Have you pushed change for review to https://gerrit-review.googlesource.com/q/project:plugins/oauth ?

davido commented 1 year ago

I uploaded this CL: [1]. Note, though it's still in review. See also this migration instruction for the reference: [2].

[1] https://gerrit-review.googlesource.com/c/plugins/oauth/+/372194 [2] https://www.keycloak.org/migration/migrating-to-quarkus#_default_context_path_changde