Add support for SSL/TLS and authenticated SMTP to any host

davidofwatkins / ge-cancellation-checker

A PhantomJS script that checks your GOES account for a sooner Global Entry enrollment appointment

173 stars 74 forks source link

Add support for SSL/TLS and authenticated SMTP to any host #7

Closed ghidinelli closed 7 years ago

ghidinelli commented 8 years ago

Localhost delivery is unlikely to work for many people so I added support for authenticated SMTP and support over SSL/TLS if you'd like to add it in. Thanks for posting to Reddit!

davidofwatkins commented 8 years ago

Thanks for the PR! Unfortunately there were some other changes merged in that have caused a conflict with this. If you're still interested, would you mind resolving them in your branch?

ghidinelli commented 8 years ago

I merged in your changes and adapted the authenticated SMTP code to your new use_gmail strategy. Tested my authenticated account successfully. I don't have an unauthenticated SMTP gateway to test but otherwise believe it's good to go.

jonluca commented 7 years ago

Only conflicting file should be the README now. Can you merge then revert the README? Or make your readme up to date @ghidinelli?

davidofwatkins commented 7 years ago

Merged, thanks!!

ghidinelli commented 7 years ago

Thanks David - this got my 3 month old daughter her GE right before we left the country on short notice so 👍

davidofwatkins commented 7 years ago

@ghidinelli Awesome :)