iOS 13 support for YouTubeStandaloneIOS

davidohayon669 / react-native-youtube

A <YouTube/> component for React Native.

MIT License

1.16k stars 472 forks source link

iOS 13 support for YouTubeStandaloneIOS #404

Open dblazeski opened 5 years ago

dblazeski commented 5 years ago

When using YouTubeStandaloneIOS on iOS 13, the app crashes with error: MPMoviePlayerViewController is no longer available. Use AVPlayerViewController in AVKit. Looks like MPMoviePlayerViewController was deprecated and completely removed on iOS 13.

Example code:

YouTubeStandaloneIOS.playVideo(youtube_id)
    .then(() => Orientation.lockToPortrait())
    .catch(errorMessage => {
        Orientation.lockToPortrait();
        StatusBar.setHidden(false);
        Linking.openURL('https://www.youtube.com/watch?v=' + youtube_id);
    })

davidohayon669 commented 5 years ago

@dblazeski seems like XCDYouTubeKit haven't upgraded yet. I'll try to look how simple is his solution, in the meanwhile, you can offer a PR

thanhcuong1990 commented 5 years ago

@davidohayon669 Please take a look my PR for this issue. #408

dblazeski commented 5 years ago

@davidohayon669 Please take a look my PR for this issue. #408

Tried the PR on iOS 12 (simulator) and iOS 13, works great!

davidohayon669 commented 5 years ago

@thanhcuong1990 had to change your code a bit in bae6948ed77f2a0371b1ee9d38cb13756445f89a, the older implementation (MPMoviePlayer) was resolving the Promise on each dismissing of the player. Using the AVPlayer I'm not sure how to achieve that, there is no point in resolving the Promise only if the video actually finishes playing (which is what AVPlayerItemDidPlayToEndTimeNotification is for) this might never happen with regular use.

If you can improve that implementation it would be great. My idea is to resolve with the promise when the playing is dismissed (The modal is dismissed) and reject if anything wrong happened between launching the modal and finishing playing the video (by dismissing the modal). AVPlayer errors should also dismiss the modal.

lukewlms commented 5 years ago

This change is now available in beta:

First, delete YTPlayerView* from the Xcode project resources folder. Then I did this, now it works:

yarn add react-native-youtube@2.0.0-beta.3
cd ios
pod deintegrate && pod install
react-native run-ios