search

davidolrik / sublime-rsync-ssh

Keep remote directories in sync with local projects.
75 stars 33 forks source link

Introduce helpers for consistent style: welcome black and pre-commit #60

Closed ctheune closed 1 year ago

ctheune commented 1 year ago

This introduces helpers for a consistent coding style. I have used the template from my company which allows local customization and can be used to update the style in the future:

https://github.com/flyingcircusio/codestyle-template/

The Github Action likely needs you to press a couple of knobs in the UI to allow them to run - not sure about that though.

davidolrik commented 1 year ago

Nice! - Thanks for that!

If you change the line length to 130, I'll merge it =)

ctheune commented 1 year ago

Oh, 130. Interesting. But yeah. Happy to oblige.

ctheune commented 1 year ago

There you go.

I don't want to bikeshed, so please feel free to ignore me: I'm from the faction of "79/80 or less" not because of "old terminals are cool", but because I buy into the typographic arguments that lines longer than 60-80 characters become hard to read and line tracking for the eyes becomes much harder.

Again, feel free to ignore to avoid bikeshedding. :)

davidolrik commented 1 year ago

There you go.

👍🏽

I don't want to bikeshed, so please feel free to ignore me: I'm from the faction of "79/80 or less" not because of "old terminals are cool", but because I buy into the typographic arguments that lines longer than 60-80 characters become hard to read and line tracking for the eyes becomes much harder.

I'm in the I bought this nice big monitor and damn it I'm gonna use it! 😁 I also agree with the those typographic arguments, but at a a slightly higher line length, given that there are syntax colouring and other such aids.

Again, feel free to ignore to avoid bikeshedding. :)

Consider it so ignored 😊